-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Short-term solution for issue 1009. #1014
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
// in return or parameter bounds expressions. | ||
// Equality between the value computed by an argument expression and its | ||
// associated temporary would also need to be recorded. | ||
Sema::NonModifyingMessage Message = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems incorrect. It can be written as:
Sema::NonModifyingMessage Message =
(CSS == CheckedScopeSpecifier::CSS_Unchecked) ?
Sema::NonModifyingMessage::NMM_None :
Sema::NonModifyingMessage::NMM_Error;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Please see issue #1009 for details.